Skip to content

fix(connectors): repair broken Zoom icon rendering#4747

Merged
waleedlatif1 merged 1 commit into
stagingfrom
waleedlatif1/zoom-icon-visibility
May 26, 2026
Merged

fix(connectors): repair broken Zoom icon rendering#4747
waleedlatif1 merged 1 commit into
stagingfrom
waleedlatif1/zoom-icon-visibility

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

Summary

  • Replace ZoomIcon SVG which had a non-square viewBox (-1 9.5 34 13) and corrupted path data, causing it to render as an ~6px-tall sliver inside the 18px connector-picker icon slot.
  • New mark is a clean Zoom video-camera shape (rounded body + lens) on a square 0 0 24 24 viewBox, filled with Zoom's brand blue #0B5CFF. Renders correctly at any size.

Type of Change

  • Bug fix

Testing

Tested manually — the Zoom entry in the Knowledge Base "Connect Source" picker now shows a recognizable Zoom mark.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped May 26, 2026 10:56pm

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented May 26, 2026

PR Summary

Low Risk
UI-only SVG swap in the shared icons module; no auth, data, or workflow logic changes.

Overview
Fixes broken Zoom connector icon by replacing the ZoomIcon SVG in icons.tsx. The old asset used a non-square viewBox and bad path data, so it showed up as a tiny sliver in fixed-size picker slots (e.g. Knowledge Base “Connect Source”).

The new graphic is a simple Zoom-style camera mark on a square 0 0 24 24 viewBox with brand blue #0B5CFF, so it scales correctly wherever ZoomIcon is mapped (blocks, landing integrations).

Reviewed by Cursor Bugbot for commit 2d2f9c6. Configure here.

@waleedlatif1 waleedlatif1 merged commit 7218185 into staging May 26, 2026
10 checks passed
@waleedlatif1 waleedlatif1 deleted the waleedlatif1/zoom-icon-visibility branch May 26, 2026 22:58
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 26, 2026

Greptile Summary

This PR fixes a broken ZoomIcon SVG that had a malformed non-square viewBox (-1 9.5 34 13) and corrupted path data, causing it to render as a tiny sliver in the connector-picker UI. The replacement uses a clean 0 0 24 24 viewBox with a simple rounded-rectangle camera body and a triangular lens path, consistent with Zoom's brand visual.

  • The old icon specified width='800px' and height='800px' hardcoded after {...props}, which would silently override caller-provided dimensions; the new icon removes these fixed size attributes.
  • The hardcoded fill='#0B5CFF' on child elements follows the same brand-color pattern used by other connector icons in the file (e.g., ZendeskIcon uses fill='#03363D').

Confidence Score: 5/5

Single-file SVG icon replacement with no logic changes — safe to merge.

The change swaps out a visually broken SVG for a clean, minimal one. The new paths are correct, the viewBox is properly square, and the brand-color approach matches what other connector icons in the same file already do. No runtime logic, no state, no API calls — impact is limited to how the icon looks in the connector picker.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/components/icons.tsx Replaces broken ZoomIcon SVG (non-square viewBox, corrupted path data) with a clean 24×24 camera-body + lens shape using Zoom's brand blue #0B5CFF

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[ZoomIcon props spread] --> B["<svg viewBox='0 0 24 24' aria-hidden='true'>"]
    B --> C["<rect x='2' y='6' w='14' h='12' rx='2.5' fill='#0B5CFF'/>\nCamera body"]
    B --> D["<path d='M16 9 L22 6 V18 L16 15 Z' fill='#0B5CFF'/>\nCamera lens"]
    style C fill:#0B5CFF,color:#fff
    style D fill:#0B5CFF,color:#fff
Loading

Reviews (1): Last reviewed commit: "fix(connectors): repair broken Zoom icon..." | Re-trigger Greptile

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2d2f9c6. Configure here.

<path d='M19.28 17.4c-0.37 0.37-0.88 0.61-1.44 0.61-1.12 0-2.02-0.91-2.02-2.02s0.91-2.02 2.02-2.02c0.93 0 1.71 0.63 1.95 1.48l0 0.01c0.05 0.16 0.07 0.34 0.07 0.53 0 0.55-0.22 1.05-0.58 1.42l0-0zM15.47 13.59c-0.65 0.62-1.05 1.48-1.05 2.45 0 1.86 1.51 3.37 3.37 3.37s3.37-1.51 3.37-3.37c0-1.54-1.03-2.84-2.44-3.24l-0.02-0.01c-0.27-0.08-0.58-0.12-0.9-0.12-0.9 0-1.72 0.35-2.32 0.93l00zM28.3 12.6c-0.8 0-1.52 0.35-2.02 0.91l0 0c-0.5-0.56-1.22-0.91-2.02-0.91-0.56 0-1.09 0.17-1.52 0.47l0.01-0.01c-0.32-0.28-0.73-0.45-1.18-0.46l0-0v6.74l0.34-0.02c0.54-0.01 0.98-0.45 1-0.99l00 0.02-0.34v-2.36l0.02-0.34c00 00 00 0-0.24 0.06-0.48 0.17-0.68l0 0.01c0.24-0.4 0.67-0.67 1.17-0.67s0.93 0.27 1.16 0.66l0 0.01c0.1 0.2 0.16 0.43 0.17 0.68v0l0.02 0.34v2.36l0.02 0.34c0.02 0.54 0.45 0.97 0.99 1l0 0 0.34 0.02v-3.71l0.02-0.34c00 00 00 0-0.25 0.06-0.48 0.17-0.68l0 0.01c0.24-0.4 0.67-0.67 1.17-0.67 0.5 0 0.93 0.27 1.16 0.67l0 0.01c0.1 0.2 0.16 0.43 0.16 0.67 0 0 0 0 0 0v-0l0.02 0.34v2.36l0.02 0.34c0.02 0.54 0.45 0.98 0.99 1l0 0 0.34 0.02v-4.04c0-1.49-1.21-2.69-2.7-2.690 00 00 0h0zM12.21 17.4c-0.37 0.39-0.89 0.64-1.47 0.64-1.12 0-2.02-0.91-2.02-2.02s0.91-2.02 2.02-2.02c0.92 0 1.7 0.62 1.95 1.47l0 0.01c0.05 0.16 0.08 0.35 0.08 0.54 0 0.54-0.21 1.02-0.55 1.39l00zM10.78 12.6h0c-1.86 0-3.37 1.51-3.37 3.37s1.51 3.37 3.37 3.37 3.37-1.51 3.37-3.37c0-1.86-1.51-3.37-3.37-3.37h-0zM6.73 18.01l-0.34-0.01h-3.03l4.04-4.04-0.02-0.34c-0.01-0.54-0.45-0.98-0.99-0.99l0-0-0.34-0.02h-5.05l0.02 0.34c0.03 0.54 0.46 0.97 0.99 1l0 0 0.34 0.02h3.04l-4.05 4.05 0.02 0.34c0.02 0.54 0.45 0.98 0.99 1l0 0 0.34 0.02h5.06l-0.02-0.34c-0.02-0.54-0.45-0.97-0.99-0.99l0-0z' />
<svg {...props} viewBox='0 0 24 24' xmlns='http://www.w3.org/2000/svg' aria-hidden='true'>
<rect x='2' y='6' width='14' height='12' rx='2.5' fill='#0B5CFF' />
<path d='M16 9 L22 6 V18 L16 15 Z' fill='#0B5CFF' />
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded blue fill invisible on blue background

Medium Severity

The new ZoomIcon uses hardcoded fill='#0B5CFF' on both child elements instead of fill='currentColor'. In the toolbar and tool-input picker, icons are rendered at 10×10px on the block's bgColor (#2D8CFF) with text-white applied to make them white. Since the hardcoded fill ignores currentColor, the icon renders as dark blue on a slightly lighter blue background, resulting in very poor contrast and a nearly invisible icon in those contexts.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2d2f9c6. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant